search

KanoComputing / kano-burners

SD Card burner for OSX
GNU General Public License v2.0
12 stars 11 forks source link

Starting the process and not choosing a disk throws an error #3

Closed radujipa closed 10 years ago

radujipa commented 10 years ago

This line https://github.com/KanoComputing/kano-burners/blob/master/kano-burner#L102 is throwing an error when no device has been selected.

Either solve this by showing a disabled button for START or create an error screen explaining the issue. I prefer the former over the later.

Thoughts @alex5imon @TommySaehl ?

radujipa commented 10 years ago

Quick fix shows an error screen when you forget to select a disk

hyperknot commented 10 years ago

The button should be unclickable while there is no disk

On 24 July 2014 20:29, Radu Jipa notifications@github.com wrote:

Quick fix shows an error screen when you forget to select a disk

— Reply to this email directly or view it on GitHub https://github.com/KanoComputing/kano-burners/issues/3#issuecomment-50066105 .

radujipa commented 10 years ago

@lucasneumann came with a great suggestion of actually hiding the button until the user selects a disk. A much better approach than an error screen!

radujipa commented 10 years ago

Hiding the button seems and then showing it after the user selected the disk looks and feels rather strange. Perhaps we could use a disabled button instead? I've got CSS styling up and running now so we can quickly experiment with text, colours, and/or images.

@TommySaehl @lucasneumann