search

KanoComputing / kano-burners

SD Card burner for OSX
GNU General Public License v2.0
12 stars 11 forks source link

add LC_ALL=C to fix i18n issues with shell cmd line, fix mislabeling of devices #30

Closed hzulla closed 9 years ago

hzulla commented 9 years ago

This might fix KanoComputing/kano-burners#28

hzulla commented 9 years ago

2nd commit might also fix KanoComputing/kano-burners#29

hzulla commented 9 years ago

Well, one should use LC_ALL, not LANG, so here it is.

hzulla commented 9 years ago

@alex5imon requesting review. Thanks.

tombettany commented 9 years ago

@hzulla This looks good. We are currently testing https://github.com/KanoComputing/kano-burners/pull/36 which we think will fix critical issue https://github.com/KanoComputing/kano-burners/issues/32 so that is the priority right now; it is a very large PR and merging this now might cause some awkward conflicts so do you mind if we put this one on hold until that is finalised?

hzulla commented 9 years ago

No, not at all. Thanks.

hzulla commented 9 years ago

In response to @alex5imon 's mail:

The GUI isn't translated in this patch. However, the LC_ALL is still necessairy, as kano-burners will parse the output of parted from the command line and will fail when the response is in locale-aware format. (Or in other words, without the added LC_ALL, kano-burners doesn't work on my Ubuntu desktop with German locale.)

Ealdwulf commented 9 years ago

I have merged this in to our development branch. Thanks very much for these @hzulla !