search

KanoComputing / kano-burners

SD Card burner for OSX
GNU General Public License v2.0
12 stars 11 forks source link

Downloader keeps running if the application is closed #5

Closed radujipa closed 10 years ago

radujipa commented 10 years ago

If you are in the downloading phase, pySmartDL is not notified that the application has been closed and continues to run in the background. Running threads should be nicely terminated.

radujipa commented 10 years ago

Despite the atexit handler added to pySmartDL it still seems to take a while for python to clean up any downloading threads. May be worth looking for a brand new downloader and upgrading the app in the future. It also creates problems with the MultistageProgressBar as it (I think) retries the download and reports 0% when the connection is not particularly good. This makes the progress bar think that the download process has finished and further progress updates are from the burning process..

hyperknot commented 10 years ago

Just modify pySmartDL as you feel like, it's only one file. Simple include it in your project and have a look at the license.

On 29 July 2014 17:01, Radu Jipa notifications@github.com wrote:

Despite the atexit handler added to pySmartDL it still seems to take a while for python to clean up any downloading threads. May be worth looking for a brand new downloader and upgrading the app in the future. It also creates problems with the MultistageProgressBar as it (I think) retries the download and reports 0% when the connection is not particularly good. This makes the progress bar think that the download process has finished and further progress updates are from the burning process..

— Reply to this email directly or view it on GitHub https://github.com/KanoComputing/kano-burners/issues/5#issuecomment-50497424 .