[Downloading] Remove pySmartDL if not used for downloading

radujipa commented 9 years ago

The project was changed to move away from pySmartDL and use aria2 for downloading purposes.

However, pySmartDL was not completely removed from the project and is creating additional python dependencies. (e.g. concurrent module, for which you would need to pip install futures)

[ ] Investigate current usage of pySmartDL
[ ] If pySmartDL is not being used for specifically downloading, remove it entirely
[ ] If pySmartDL is used for other operations (e.g. md5 checks), use lightweight alternatives (i.e. native python)
[ ] Update wiki pages to reflect changes

Ealdwulf commented 9 years ago

The linux code in the burner wasn't updated to support aria2. That would be require some thought because it goes against the spirit of linux to supply a binary of aria2 like we do for windows and osx. some options are:

Drop linux support
Keep pySmartDL just for linux
request the user to install aria2 manually if it isn't present

radujipa commented 9 years ago

At the moment, I believe there is an issue with the Linux version mainly because of pyinstaller since it doesn't seem to package PyQt4. This might need some further investigation as to whether this issue has been fixed, or perhaps the packaging process is different on Linux and has been wrong the whole time. I've opened another ticket https://github.com/KanoComputing/kano-burners/issues/64

Keeping pySmartDL for Linux creates additional nasty dependencies in OSX and Windows, and I would advise against it
It probably won't come as a surprise to the average Linux user to have to install a dependency for an app, so I like this alternative for the time being - in the future if we release the burners on pip, we could add aria2 as a dependency

I would also advise against dropping support for Linux, as the app works fine if run from source. For the tech savy, it may still prove a useful tool with the documentation in the wikis. We might even get external collaboration on it in that case.

sudhanshuptl commented 6 years ago

Facing issue while downloading file it just break after few 100mb and it show as download comppleted and restart download and loop continue

Ealdwulf commented 6 years ago

We no longer support this tool; we now recommend using etcher

KanoComputing / kano-burners

[Downloading] Remove pySmartDL if not used for downloading #63