search

KanoComputing / make-art

App to learn programming using a basic CoffeeScript drawing API
GNU General Public License v2.0
47 stars 37 forks source link

I18n support and Japanese translation (jessie) #330

Closed japonophile closed 8 years ago

japonophile commented 8 years ago

This is an initial translation of the Kano "Draw" application. Translations have been tested both in online (browser) and offline (on Kano) modes.

In order to see the translations on Kano, you need to select Japanese as default language (through dpkg-reconfigure locales) and install necessary fonts through apt-get. See http://www.rs-online.com/designspark/electronics/knowledge-item/JPN-raspberry-pi-Japanese-version for details.

The build process gulpfile.js has been modified to also copy the translations and translate the views (using the gulp-html-i18n plugin). All translations are available in www after a successful build, so the application can easily be installed.

This PR includes translations for all "Basic" and "Medium" challenges, as well as "Pong" in "Pixel Hack". I am planning to translate the remaining challenges as well.

Note: in order to set the user language and see the translated app in Kano Webkit, a small modification is needed in webapp.py, in kano-toolset project (see separate PR for this).

There is no impact to the English version of the app.

arifshanji commented 8 years ago

@japonophile This is brilliant work. We have been discussing localisation for this product for a while now and appreciate your time in laying the foundations for this. I had a quick glance at the code and it seems to be the right approach. We'll do more testing and get back with some feedback shortly.

japonophile commented 8 years ago

@arifshanji Thank you so much for the feedback! I am happy to hear the approach seems reasonable to you. Let me know if you have any feedback, so I can improve it as needed. If this PR can be merged, I'll spend more time translating the more advanced challenges too.

jkimbo commented 8 years ago

Apart from a couple of comments it all looks good! The main issue will be that we need to support country localisations beyond just language ones but I don't think that will be too complicated to integrate.

jkimbo commented 8 years ago

@japonophile I'm going to close this PR in favour of https://github.com/KanoComputing/make-art/pull/332 (it contains all your work plus some minor changes that we needed). Thanks again!