KanoComputing / make-art

App to learn programming using a basic CoffeeScript drawing API
GNU General Public License v2.0
47 stars 37 forks source link

[OS-1023] Fix build for Kano OS #450

Closed lauraenria closed 4 years ago

lauraenria commented 4 years ago

Our goal, to integrate the new changes in make-art with Kano Os when it's built, is reached by:

lauraenria commented 4 years ago

Our goal, to integrate the new changes in make-art with Kano Os when it's built, is reached by:

  • Installing we kit-app-shell-web
  • installing the appropriate commands, like yarn, node, npm-login-cmd to login in npm and its requirements npx. We need the offline version and to run both yarn build for the style in gulp and yarn build:web for the complete built. Environment variables would be set up outside in a safer place.
  • set up the right path for Make-art in Kano-draw.install for a few elements which were missing and not reachable thought the server, even if copied.
  • Set up the check condition for Windows (isThisAWindowsMachine?) before the required variables are defined.
  • I found useful to add in the readme about vscode Rasbian

Should I delete about vscode Rasbian and self._inspector = True to inspect the browser? I think they may be useful. There alre also few commands commented which I am not sure I should delete in rules. And I guess I should delete too shell-cli and shell-ios

tombettany commented 4 years ago

Something really isn't right here - I don't understand how there are so many file changes. Like the fonts - they should just be copied at build time from the node module that supplies them and I'm not so sure about deleting everything in the www directory. Also, how have you added so many files?

tombettany commented 4 years ago

Sorry, clicked the wrong button - didn't mean to close.

tombettany commented 4 years ago

Replaced by https://github.com/KanoComputing/make-art/pull/451