search

Kantis / ks3

KotlinX Serialization Standard Serializers (KS3)
Apache License 2.0
20 stars 4 forks source link

Use Kotlin's built-in Base64 en-/decoding #116

Closed sschuberth closed 9 months ago

sschuberth commented 9 months ago

This requires to raise the Kotin API level to 1.8.

sschuberth commented 9 months ago

I'm not sure what needs to happen to the occurrence of base64id in gradle/kotlin-js-store/yarn.lock... if anything.

sschuberth commented 9 months ago

Also, should we now move the only remaining file ByteArrayAsBase64StringSerializer.kt out of the base64 package, and remove that package?

Kantis commented 9 months ago

Yeah, sounds like the package is not really needed anymore 👍🏼

sschuberth commented 9 months ago

Yeah, sounds like the package is not really needed anymore 👍🏼

I've added a commit for the move.

sschuberth commented 9 months ago

I'm not sure what needs to happen to the occurrence of base64id in gradle/kotlin-js-store/yarn.lock... if anything.

Can you still comment on this one @Kantis? Does anything need to be done here?

Kantis commented 9 months ago

I'm not sure what needs to happen to the occurrence of base64id in gradle/kotlin-js-store/yarn.lock... if anything.

Can you still comment on this one @Kantis? Does anything need to be done here?

Sorry, missed that. Nothing to be done. It looks like a transitive dependency of Karma and is unrelated to our base64 serialization. (JS lib used by Kotlin/JS afaik)