search

KaotoIO / kaoto-backend

Backend for the Kaoto project to provide an easy to use integration framework based on Apache Camel.
Apache License 2.0
75 stars 32 forks source link

Publish multi-arch docker image #288

Closed apupier closed 1 year ago

apupier commented 1 year ago

Is your feature request related to a problem? Please describe.

Currently image is single arch. There is a different label for Mac (*-arm64) which can be confusing as arm64 can also be used for Linux. Also there is no Windows image.

Describe the solution you'd like

Provide a multiarch image on the same tag.

Describe alternatives you've considered

Additional context

https://docs.docker.com/build/building/multi-platform/#example

it is currently a problem for VS Code Kaoto but I think we will move away from docker and use native executable directly in VS Code Kaoto. It remains a good practice if we want to provide Docker images.

mmelko commented 1 year ago

So you really don't need to have multi-arch images. Current one works just fine on both in windows and arm64. It might be a labelling problem though. It might be necessary to set this for arm64 docker.

apupier commented 1 year ago

For VS Code, no more need. Swithcing to native binaries was the long term goal anyway.

For normal users, they will surely expect a multiarch as most of the Docker images are built this way.

For Windows, which label should be used currently?

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 1 year ago

This has been closed due to inactivity. If you want to further pursue this development, please reopen it again adding the new information.