search

KaotoIO / kaoto-backend

Backend for the Kaoto project to provide an easy to use integration framework based on Apache Camel.
Apache License 2.0
75 stars 32 forks source link

fix: Rest verb/uri has been renamed to path #855

Closed igarashitm closed 1 year ago

igarashitm commented 1 year ago

Fixes: #854

From 3.16 https://camel.apache.org/manual/camel-3x-upgrade-guide-3_16.html#_renamed_uri_to_path

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (621003f) 70.68% compared to head (a2b8973) 70.68%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #855 +/- ## ========================================= Coverage 70.68% 70.68% Complexity 199 199 ========================================= Files 69 69 Lines 3364 3364 Branches 565 565 ========================================= Hits 2378 2378 Misses 766 766 Partials 220 220 ``` | [Files Changed](https://app.codecov.io/gh/KaotoIO/kaoto-backend/pull/855?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=KaotoIO) | Coverage Δ | | |---|---|---| | [...rser/step/camelroute/CamelRestDSLParseCatalog.java](https://app.codecov.io/gh/KaotoIO/kaoto-backend/pull/855?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=KaotoIO#diff-Y2FtZWwtc3VwcG9ydC9zcmMvbWFpbi9qYXZhL2lvL2thb3RvL2JhY2tlbmQvY2FtZWwvbWV0YWRhdGEvcGFyc2VyL3N0ZXAvY2FtZWxyb3V0ZS9DYW1lbFJlc3REU0xQYXJzZUNhdGFsb2cuamF2YQ==) | `97.52% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lordrip commented 1 year ago

Using the step extension, doesn't include the path property, so probably more adaptation is required from it

image

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.0% 2.0% Duplication

igarashitm commented 1 year ago

@lordrip can you upload the original YAML? (or OpenAPI spec?)

lordrip commented 1 year ago

@igarashitm I updated the Rest DSL Step extension to work with both properties, path and uri, this should be good now.

Local build

image

Current deployment

image

lordrip commented 1 year ago

Also, the schema now supports routeConfiguration and restConfiguration :tada:

image