search

Kapeli / Dash-User-Contributions

Dash repo of user contributed docsets
2k stars 851 forks source link

Update RFCs docset #5156

Closed pointlessone closed 1 month ago

pointlessone commented 2 months ago

The docset file: RFCs.tgz.

github-actions[bot] commented 2 months ago

Test result: PASS 🟢

Kapeli commented 1 month ago

The link points to a file that does not exist (error 404).

pointlessone commented 1 month ago

Sorry, fixed.

Kapeli commented 1 month ago

The docset should be directly inside the archive (i.e. don't archive any enclosing folder). In your archive the docset is inside a dist folder.

I've remade the archive. If you can, please make sure to archive the docset directly on your next submission.

Sorry for the inconvenience!

pointlessone commented 1 month ago

Thank you. Absolutely.

weppos commented 1 month ago

@Kapeli @pointlessone I used to be the maintainer of the RFC docset (see https://github.com/Kapeli/Dash-User-Contributions/pull/2480), that was originally created by @willnorris

The repo was not updated for a few years as the RFCs were migrated. Last month all the issues were cleared, and I started the process to get the docset ready for publishing.

However, as I came here today, I noticed that last week the repo was replaced with a new one in this PR.

How do you want to move forward in addressing the conflict? Any preference?

Kapeli commented 1 month ago

@weppos Can you point me to a downloadable docset with @Tenzer's changes? My preference would be towards users getting the version of the docset with the least issues, so I'd start by comparing the 2 docsets. As I'm not familiar with this docset, any help / suggestions are greatly appreciated.

weppos commented 1 month ago

Sure thing. Please give me until next week, this one I have limited connectivity.

weppos commented 3 weeks ago

@Kapeli I uploaded the file, you can find it at https://storage.googleapis.com/rfcdash/RFCs.docset-v2.0.0.tgz

Also referenced in https://github.com/willnorris/rfcdash/blob/master/RFCs.xml

weppos commented 4 days ago

Hi @Kapeli, did you have the chance to take a look? Anything I can help with?

Kapeli commented 4 days ago

Sorry, I missed your previous comment.

The docsets seem to be very similar.

The docset by @pointlessone has table of contents support for the RFCs that have the nicer page styling. See screenshots.

Screenshot 2024-11-18 at 12 17 39 Screenshot 2024-11-18 at 12 17 42

Can you find any issues/shortcomings in the docset by @pointlessone?

pointlessone commented 4 days ago

My code is in Ruby so it's not exactly compatible with @weppos script. I'm fine if it's being used as reference (it's under Apache license) if @weppos is willing to maintain it and update the docset once in a while.