added Feature to import Docsets via the 'openInMenu'

Kapeli / Dash-iOS

Dash for iOS was discontinued. Please check out Dash for macOS instead.

https://kapeli.com/dash

Other

7.13k stars 924 forks source link

added Feature to import Docsets via the 'openInMenu' #52

Closed insightmind closed 7 years ago

insightmind commented 7 years ago

I added the feature to import Docsets via the 'openInMenu' in iOS.

Now it is possible to upload a .docset file to iCloud or any other CloudPlatform and import them directly on the iOS device into Dash. This is especially suitable for use with the iOS11 Files App.
It is now also possible to import the Apple API Reference without iTunes File Sharing.

Kapeli commented 7 years ago

As far as I can tell this doesn't give any feedback to the user or open the Transfer Docset view? Is this correct?

insightmind commented 7 years ago

Yes, it only implements the possibility to copy a docset via the 'openIn' Menu to the transerPath. The only pop-up-view that shows up, is the native copying pop-up-view in iOS11. For user feedback, a change in the info-text of the TransferDocset-View or/and the automatic opening of the TransferDocset-View should be considered. I would improve my pull request if this feature is preferred.

insightmind commented 7 years ago

After some time, I was finally able to update the pull request. I now included a UIAlertController which gives feedback to the user after the docset was imported or an error occurred.

Kapeli commented 7 years ago

Please clean up your code (e.g. indent it).

insightmind commented 7 years ago

screen shot 2017-10-04 at 6 07 18 pm Correctly indented in Xcode ... Strange

Kapeli commented 7 years ago

Thank you! 👍