search

Kapeli / Dash-iOS

Dash for iOS was discontinued. Please check out Dash for macOS instead.
https://kapeli.com/dash
Other
7.13k stars 928 forks source link

[WIP] Feature/spotlight integration #77

Closed clementpadovani closed 6 years ago

clementpadovani commented 6 years ago

This is an initial work to get Spotlight integration with Dash.

Please note that this only applies to Apple docsets for now.

@Kapeli How could we display the results when we open a search result?

A search result gets identified via the request_key attribute of a row in the optimized DB.

Contributions are welcome

Kapeli commented 6 years ago

I don't think this should be done. Spotlight doesn't search the way Dash does and the results it will show would be incomplete. The integration makes it seem like Dash's search is failing, while the truth is Spotlight searches in a different way.

Hopefully Apple will sometime allow third party apps to feed results directly into Spotlight, and not insist on having Spotlight do the searching.

This is coming from my attempts of supporting Spotlight on macOS, but I assume it's the same with iOS.

@Kapeli How could we display the results when we open a search result?

I don't think you would. Just show the result's page.

Kapeli commented 6 years ago

Closing due to inactivity.