search

Kapeli / Dash-iOS

Dash for iOS was discontinued. Please check out Dash for macOS instead.
https://kapeli.com/dash
Other
7.13k stars 924 forks source link

iPhoneX landscape UI issue--Bug Resolved #79

Closed DmytriE closed 6 years ago

DmytriE commented 6 years ago

There is an issue reported by qinyuhang that the notch on the iPhone X hides the RightDetailLabel. Noticing that there is a constraint applied to the BrowserTableViewCell which keeps the label on the iPhone screen the code in the layoutSubviews function in DHBrowserTableViewCell has been commented out.

Additionally, a number of functions have been commented to help explain what each function does.

Kapeli commented 6 years ago

Please create a separate pull request that only fixes the bug.

I am currently only accepting pull requests that fix bugs or add/improve features. I can't allocate time to review pull requests that only refactor things or add comments.

DmytriE commented 6 years ago

It does fix the bug. It just adds comments to document the purpose of other functions as an addition.

Dmytri Eck

On Jul 21, 2018, at 18:44, Bogdan Popescu notifications@github.com wrote:

Closed #79.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

Kapeli commented 6 years ago

Great. Please create a separate pull request for the bug fix. I can't review 110 changed files to find a bug fix.