Kaperstone / mogilefs

Automatically exported from code.google.com/p/mogilefs
0 stars 0 forks source link

DevFID get_size is a 'lil busted #17

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
The "get file size" routine is an overcomplex mess. First it attempts to use a 
mogstored sidechannel, then defaults back to HEAD. Except if mogstored is not 
there, not functioning, etc, it'll cause frequent delays.

I'm not sure the side channel is any faster or even necessary with the FSCK 
mass-statter disabled. Should consider gutting out all of the code and doing a 
simple HEAD request via LWP.

If we add in sidechannel support (now or later), it should try a lot harder to 
avoid testing for availability.

Original issue reported on code.google.com by dorma...@rydia.net on 1 Oct 2010 at 1:19

GoogleCodeExporter commented 8 years ago
Fixed in the 'next' tree. Rewritten to use LWP::UserAgent.

Also has backoff retries, so it'll ping demolished hosts far less often.

Original comment by dorma...@rydia.net on 27 Jul 2011 at 11:33