Kapiainen / Lauhdutin

A Rainmeter skin for launching games.
MIT License
67 stars 8 forks source link

Added option to choose how many backups you want #101

Closed BanCrash closed 6 years ago

BanCrash commented 7 years ago

Added the option to manually choose how many backups you want to make.

I don't add the pertinent option in settings yet because there is already other pull request that changes the settings. When that PR be accepted or rejected if this is going to be accepted I will create that option too.

Kapiainen commented 7 years ago

It's going to take a while for pull requests to be accepted. I've been slowly working on a framework for creating general settings skins for Rainmeter and my intention is to then overhaul Lauhdutin's settings skin to use that new framework. The framework will basically make it so that one can define pages of settings in Lua and each page can have N number of settings. So no more of the current situation where you have to resize, move, and create new meters and such to add settings. Instead you can just define a new page in Lua with certain types of settings (integers, floats, strings, paths, etc). The framework will then set the values of meters (setting title, current value, etc) when a page is loaded as you browse through the various pages of settings.

Progress is going to be even slower now that I have a very busy period at work for the next 2 months or so. Pull requests for fixes and additions are still welcome, but it can take quite a while before I have my changes done and I have time to merge pull requests.

BanCrash commented 7 years ago

That sounds very useful indeed! Thanks for letting me know.

I don't have any problem on wait, I just wanted to explain why I didn't make a complete PR. Have all the time you want, your life goes first of course.

Kapiainen commented 6 years ago

This feature is included in an upcoming version.