Skin not showing hours properly

[BanCrash]

Hello! I found two little issues related to hours showed. I'm using last beta.

• When a game only has one hour of play skin is showing "1 hours" instead "1 hour":

• When a game has more than "x.5" hours skin is showing "x+1 hours" instead "x hours". For example, in NBA 2K17 I have "17.7" in games.json, and the skin is showing "18 hours" instead "17 hours". But maybe it's a feature and not an issue?

[Kapiainen]

When a game has more than "x.5" hours skin is showing "x+1 hours" instead "x hours". For example, in NBA 2K17 I have "17.7" in games.json, and the skin is showing "18 hours" instead "17 hours". But maybe it's a feature and not an issue?

That is intentional. The number of hours played is always rounded up or down.

When a game only has one hour of play skin is showing "1 hours" instead "1 hour":

That should probably be handled with a separate translation string for the case where the value is rounded up or down to 1. For the English translation one could get away with using X hour(s), but that would not work for all languages (e.g. Swedish has the pattern 1 timme and 2+ timmar).

[Kapiainen]

I just pushed a commit that adds a translation string for the case where a game has been played for approximately 1 hour (i.e. the value is rounded up or down to 1).

[BanCrash]

That is intentional. The number of hours played is always rounded up or down.

Well then!

I just pushed a commit that adds a translation string for the case where a game has been played for approximately 1 hour (i.e. the value is rounded up or down to 1).

Perfect, thanks you!!