search

Kapiainen / Lauhdutin

A Rainmeter skin for launching games.
MIT License
67 stars 8 forks source link

Added ability to search uninstalled and hidden games #134

Closed BanCrash closed 6 years ago

BanCrash commented 6 years ago

Hello! I added the ability of searching on hidden and / or uninstalled games that were on 2.x version. I added the pertinent settings and by default are disabled. I made the changes to moon files and then I compiled them.

To use this is necessary to use a 3.0.x settings file or delete previous 3.1 settings file, because a new table is added to version 2 migrators, but if settings are already on version 2 will not be added, causing the skin to fail to launch.

I tried to keep consistency with the code. I also complicated a little bit hidden filtering to avoid the scenario where a game is hidden and uninstalled, and show hidden games is enabled but show uninstalled games is disabled, so without that modification will show that game even if it's uninstalled.

I tested it with every scenario that come to mind and don't found any issue.

Feel free to reject this, ask for any changes or any explanation regarding my modifications.

Kapiainen commented 6 years ago

Thanks! I did a quick test and I didn't see any issues with the implementation.

BanCrash commented 6 years ago

Perfect! Thanks you!!