Issues with animations - Githubissues

BanCrash commented 7 years ago

Hello again, I found that if Zoom In hover animation is enabled, when you hide a game the banner still appearing until you stop on hover it. With jiggle that doesn't happen, or with that option disabled.

Other issue, shake hover animation is not working I think, at least I don't see any change in the banner.

And finally, in Zoom in hover animation I don't know if this a bug or it works like it has to work, I don't see much problem with this but just in case it is a bug I share it. When you hover a banner with unused banners around, you can see the complete image:

Kapiainen commented 7 years ago

Hello again, I found that if Zoom In hover animation is enabled, when you hide a game the banner still appearing until you stop on hover it. With jiggle that doesn't happen, or with that option disabled.

Fixed in the upcoming version.

Other issue, shake hover animation is not working I think, at least I don't see any change in the banner.

Fixed in the upcoming version.

And finally, in Zoom in hover animation I don't know if this a bug or it works like it has to work, I don't see much problem with this but just in case it is a bug I share it. When you hover a banner with unused banners around, you can see the complete image:

That is definitely a bug. The new way of handling slot animations works by:

Using a separate image meter, which is drawn below all slot meters, for animations to ensure that the animated banner does not end up covering the banners of slots around it.
Using a shape meter, which is drawn between the actual slot meters and the animation meter, to act as a mask so that the animated banner does not end up covering empty slots or slots without banners.

So the behavior that can be seen in your screenshots should not be happening. I tried reproducing the issue, but I have not been able to do so yet.

lauhdutin-issue70-repro

Kapiainen commented 7 years ago

Could you check what the value of the SlotBackgroundColor variable is when you have Lauhdutin running? Just go to Rainmeter's Log window, click on the Skins tab, and select the correct skin. You should see a list of measures and variables on the right-hand side of the window. You should see something like slotbackgroundcolor 0,0,0,255. I suspect the alpha value (fourth number in my example) is below 255 in your screenshots. If it is below 255, then the shape meter, which acts as a mask, will be translucent rather than opaque as was intended.

EDIT: Regarding the discussion about performance in issue #62, it looks like the performance is dependent on the number of visible banners. For example a 6x8 grid with visible banners in all slots is slow, but the same grid with only 6 slots with visible banners is not slow.

Kapiainen commented 7 years ago

Beta 4 addresses the last issue that you brought up. The Python script that builds a part of the skin was set to use a legacy setting (from versions prior to 2.0.0), but the color is hard coded into the script for now and will ignore the value that may have been left behind in the settings file.

BanCrash commented 7 years ago

Well, that was fast, thanks you one more time!!

About your edit of the perfomance you're right, and I think the problem is with the images. Because I set a grid of 6x7 with 310x145 slot size and it works laggy, but the same grid with 155x73 slot size works like a charm. The games are the same, the only thing changes are the images size, so I think the problem is that.

Kapiainen / Lauhdutin

Issues with animations #70