KapitanOczywisty / language-php

PHP package for Atom
Other
3 stars 3 forks source link

Types definitions for PHP 8.2 #2

Closed KapitanOczywisty closed 1 year ago

KapitanOczywisty commented 1 year ago

Implemented RFCs: https://wiki.php.net/rfc/null-false-standalone-types https://wiki.php.net/rfc/true-type https://wiki.php.net/rfc/dnf_types

Like before, there are 2 stages: one is detecting the general type hint structure, the second is extracting exact tokens. Multiline types are still not supported, which might be desired with introduction of more complex types. First stage regex is identical in different parts of code:

KapitanOczywisty commented 1 year ago

@roblourens It took me a bit longer to get around than I've estimated, but PRs are now ready. Can you take a look at the new PRs? I suspect it's too late to make into February update, or is it?

roblourens commented 1 year ago

Thanks for doing this- yeah I can start pulling code from this repo for the March release.

KapitanOczywisty commented 1 year ago

@roblourens I'd like to merge PRs before March release. If you don't see anything wrong, I'll merge them, and update VSCode grammar.

roblourens commented 1 year ago

Looks fine to me. I was a bit preoccupied during March but assigned https://github.com/microsoft/vscode/issues/162707 to the April milestone