search

Karaka-Management / phpOMS

PHP Framework
Other
2 stars 0 forks source link

It feels like that name and type in BaseStringL11n sometimes are used for the same purpose #357

Open spl1nes opened 7 months ago

spl1nes commented 7 months ago

File: phpOMS/Localization/BaaseStringL11n.php

Maybe we can always use $type and remove $name.

This would require some smart mapper adjustment where the name is part of the l11n model. Maybe use the path definition in the mapper which is used by arrays (e.g. type/name).

More maybe: $name might have been intended as internal value? -> Makes no sense because only string