search

Karaka-Management / phpOMS

PHP Framework
Other
2 stars 0 forks source link

The on part of a join doesn't allow string values because they conflict with column names #369

Open spl1nes opened 7 months ago

spl1nes commented 7 months ago

File: phpOMS/DataStorage/Database/Query/Grammar/Grammar.php

if (isset($element['value'])) {
  $expression .= ' ' . \strtoupper($element['operator']) . ' '
      . (\is_string($element['value']) ? $this->compileSystem($element['value']) : $element['value']);
}

Other data types are possible because they don't conflict with the data type of columns (string) Consider to create a ColumnName() class.