search

KaranveerB / typhon

e-book reader with Rikai-like Japanese dictionary lookup for Android
GNU General Public License v3.0
3 stars 0 forks source link

Merge relevant enhancements/bug fixes from other forks to this fork #6

Open rampaa opened 1 year ago

rampaa commented 1 year ago

Like https://github.com/krukgit/typhon/commits/master (and maybe https://github.com/tanbotonbo/typhon/commits/master?)

KaranveerB commented 1 year ago

The code from kukgit's fork (or more specifically the forks leading up to it) is honestly a bit of a mess and are not as useful to me so I probably won't be merging it all. If you want those features, it'd probably be best for you or someone else to fork krukgit's fork and merge my changes rather than the other way around.

What specifically are you looking for? Native audio is probably a no, and e-ink is fine, but not in the way it's implemented in the fork.

Currently I'm considering adding makuto's IPA font, and huh88's dictionary spacing and anki fixes. Tanbotonbo's fork I may just merge entirely.

rampaa commented 1 year ago

What specifically are you looking for?

Nothing specific to be honest. I've kinda assumed maybe you've missed the existence of those forks and that's why you didn't merge the changes made by them. If not merging those changes was a conscious decision then feel free to ignore this request.