codello commented 2 years ago

Note: This PR should be reviewed/merged after #3

This PR adds two endpoints /authorize and /token corresponding to the respective OAuth 2.0 endpoints. Currently I'm planing on implementing two of the OAuth flows:

Password Grant: for authentication against a local user database or potentially against an ldap backend
Authorization Code Flow: for a generic OAuth authentication. The endpoint supports a mechanism to select an backend that may be configured through the application's settings. This way one might implement social logins.

The endpoints could theoretically used to include a fully fledged OAuth server in the Karman API or to connect an external OAuth provider such as Auth0 (or both). This may be a more robust and elegant solution down the road…

codecov[bot] commented 2 years ago

Codecov Report

Merging #4 (cd0a5b8) into main (19ec4cf) will not change coverage. The diff coverage is 0.00%.

@@          Coverage Diff           @@
##            main      #4    +/-   ##
======================================
  Coverage   0.00%   0.00%            
======================================
  Files          9      12     +3     
  Lines        125     244   +119     
======================================
- Misses       125     244   +119

Impacted Files	Coverage Δ
karman/config.py	`0.00% <0.00%> (ø)`
karman/main.py	`0.00% <0.00%> (ø)`
karman/routes/auth.py	`0.00% <0.00%> (ø)`
karman/schemas/auth.py	`0.00% <0.00%> (ø)`
karman/security.py	`0.00% <0.00%> (ø)`
karman/util/openapi.py	`0.00% <0.00%> (ø)`
karman/versioning.py	`0.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 19ec4cf...cd0a5b8. Read the comment docs.

TheMcs000 commented 2 years ago

@codello I had to merge with main. Please check if I did it correctly. If so, please merge the pull request yourself

Karaoke-Manager / legacy-backend

Add Authentication #4

Codecov Report