Open farishkash opened 7 years ago
Karatesaurus-Rex
commented
7 years ago This was immensely helpful advice. I really appreciate the quick synopsis despite submitting the assignment late. Nonetheless, my jaw dropped at the utility of the learning game you sent me and I will absolutely be trying to get ahead using it to polish my skills.
Thank you so much for taking the time to help me, I am sure that going forward I will be able to refine my approach to make tighter code!
Karatesaurus-Rex
commented
7 years ago I finished the froggy game! It was quite fun solving that last puzzle, and I even managed to do it with one extra line to spare because I kept efficiency in mind.
If you have the time, I would love to devour any other extracurricular stuff you can think of. I don't know what flexbox is, but I feel pretty confident that when it shows its face, I'll be able to manipulate it well and align the heck out some stuff now. Thanks for recommending it.
Overall met expectations.
In this first submission I look for two items.
Did you use divs, classes/ids to organize your content and apply styles.
Yes you did. I felt you were not being efficient. You had some extra div usage that really wasn't needed.
Second is your css efficient and non repetitive.
You are repetitive font-family. The goal here is to try to tight as little as possible to get the job done. The later projects have 300-500 lines of css. Reducing how much you type helps for two reasons. First the less you type to get the job done, the less likely you will make a mistake. Second, if you do make a mistake, the faster you can figure out your error because you have less css to read through.
To prepare you for the upcoming projects I like you to go to flexboxfroggy.com. See how far you can get, the later projects uses flexbox heavily and this will help you immensely.