Closed zhx828 closed 1 year ago
Hi Hongxin, Thank you so much for using OpenCravat and we are so happy we can include OncoKB! After reading through your requested changes, the following updates have been made to the oncokb annotator in version 1.1.3 and the corresponding widget wgoncokb version 1.0.2. I wanted to first address your suggestions about the reference genome and the different genome options for the OncoKB annotator. OpenCravat users can always choose what genome to run their job in, but it is always converted to hg38 coordinates and that's why the referenceGenome is set to hg38. If the user would like to run the job in hg37, their coordinates will be converted to hg38 prior to the API call, and the hg37 coordinates can still be viewed under the Original Input section of the variant table.
Please let me know your thoughts and if these changes are acceptable.
Hi team, thanks again for including OncoKB on this great tool! I'm trying to validate some of the annotation to see whether they are properly annotated. Could you help make the following changes? I'd also happy to maintain this tool if you think that's better going forward.
referenceGenome
should not be set to 38, but rather depends on what user's genome SelectionThank you in advance.