search

KarchinLab / open-cravat

A modular annotation tool for genomic variants
MIT License
110 stars 27 forks source link

bugfix admin_util.py had a bug during dependency cleanup #159

Closed cariaso closed 1 year ago

cariaso commented 1 year ago

oc module install -y ancestrydna-converter ERROR '1' Repeat command with --debug for more details

oc module install -y ancestrydna-converter --debug Traceback (most recent call last): File "/usr/local/lib/python3.9/site-packages/cravat/oc.py", line 238, in main args.func(args) File "/usr/local/lib/python3.9/site-packages/cravat/cravat_admin.py", line 304, in install_modules deps = au.get_install_deps(module_name, version=version) File "/usr/local/lib/python3.9/site-packages/cravat/admin_util.py", line 598, in get_install_deps remove_locally_installed_deps(deps) File "/usr/local/lib/python3.9/site-packages/cravat/admin_util.py", line 543, in remove_locally_installed_deps del deps[name] KeyError: '1'

The variable to_delete needs to be a list of names. previously it was a long string of concatenated version details

kmoad commented 1 year ago

Greatly appreciate the find and fix here. However, this bug had a fix in dev when the pr was made.

https://github.com/KarchinLab/open-cravat/commit/2164d71a457c24889081b3e4c5cbf14449c6e6ee

The fix has been released in version 2.4.1.