search

KarchinLab / open-cravat

A modular annotation tool for genomic variants
MIT License
110 stars 27 forks source link

python 3.12 module imp deprecated #214

Closed Kaddea closed 2 months ago

Kaddea commented 4 months ago

Just a short info that the module "imp" is deprecated in python 3.12 (ubuntu 24.04 noble).

"import imp" in site-packages/cravat/cravat_web.py (line 10) can be removed (importlib is imorted later anyway)

and in site-packages/cravat/webresult/webresult.py (line 6) it needs to be extendet to "import importlib"

there is still one syntax warning site-packages/cravat/webresult/webresult.py:270: SyntaxWarning: invalid escape sequence '_' q = 'select * from info where colkey not like "_%" escape "\"'

but it's running fine so far :)

kmoad commented 4 months ago

Ah, we've been building on 3.11. We'll test it out on 3.12. Thanks for the catch!