Kareadita / Kavita

Kavita is a fast, feature rich, cross platform reading server. Built with the goal of being a full solution for all your reading needs. Setup your own server and share your reading collection with your friends and family.
http://www.kavitareader.com
GNU General Public License v3.0
6.16k stars 320 forks source link

Issues with special numbers don't show up in the Issues tab #1293

Closed dreaganluna closed 2 years ago

dreaganluna commented 2 years ago

Describe the bug Issues with special numbers don't show up in the Issues tab (ex.: #1.MU, #00, #½, ...).

To Reproduce Steps to reproduce the behavior:

  1. Import a comic issue with a special number
  2. Go to the issue's series and look the volume's details (issue is listed here)
  3. Go the to series' Issues tab (issue is not listed here)

Expected behavior Issues with a special number should show up and be possible to read.

Screenshots https://ibb.co/nnwrr95 https://ibb.co/j6sJQTF (Issues tab contains 3 different volumes worth of issues)

Desktop (please complete the following information):

majora2007 commented 2 years ago

Please provide the filenames (assuming no comicinfo) and where they map into.

dreaganluna commented 2 years ago

Filenames: Fathom Vol.1998 #00 (June, 1998).cbz Fathom Vol.1998 #½ (February, 1998).cbz

They do have comicinfo xml files though. I'll provide snippets with the relevant information below.

<?xml` version="1.0"?>
<ComicInfo xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
  <Series>Fathom</Series>
  <Number>0</Number>
  <Volume>1998</Volume>
  <Format>Series</Format>
</ComicInfo>
<?xml version="1.0"?>
<ComicInfo xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
  <Series>Fathom</Series>
  <Number>½</Number>
  <Volume>1998</Volume>
  <Format>Series</Format>
</ComicInfo>

I'm not sure what you mean by where they map into.

majora2007 commented 2 years ago

Issue 0 is not supported, ½ isn't a real number, so it makes sense that it would map as a special rather than a standard issue. This isn't really a bug, but rather a limitation of how I built Kavita originally for manga and adapted comics, not knowing 0 issues were a thing.

Best bet is to use #00.1 or something if you want it in Storyline tab.

dreaganluna commented 2 years ago

I am definitely not making these up. These non-numbers are mainly used for marketing purposes, but they do exist and are used a lot, and in mainline series.

An example of a company-wide #0 issue, across 52 running series at the time for DC was "Zero Month": https://comicvine.gamespot.com/the-new-52-zero-month/4015-56141/ https://retcon-punch.com/zero-month/

0 issues exist in a large number of super hero comics. I've even seen it happen in manga recently:

https://www.viz.com/read/jujutsu-kaisen/section/73059/more

Marvel even uses letters in their numbering, which must have annoyed DBA's when they started using them.. 😄 They do this in comic book events that aren't big enough for crossovers into other mainline series. For example, the recent Beyond storyline in Amazing Spider-Man had a number of tie-ins. And to make sure people bought them, they just added them to the Amazing Spider-Man series with ".BEY" appended to already existing numbers: https://marvel.fandom.com/wiki/Amazing_Spider-Man_Vol_5_88.BEY

So these aren't that uncommon unfortunately..

majora2007 commented 2 years ago

I'm not saying you are, I'm saying it is a limitation in how Kavita was designed and not something I can change at this point.

dreaganluna commented 2 years ago

Fair enough. :) Should I raise this as a feature request here?

Do you know if there's a way to track down these missing issues?

majora2007 commented 2 years ago

You can open one but as mentioned, I won't be implementing. This is just a drawback of Kavita.

I would assume search or checking the logs.