search

Kareadita / Kavita

Kavita is a fast, feature rich, cross platform reading server. Built with the goal of being a full solution for all your reading needs. Setup your own server and share your reading collection with your friends and family.
http://www.kavitareader.com
GNU General Public License v3.0
6.29k stars 327 forks source link

Non-integer comic volume not shown on series page #1606

Closed pssandhu closed 1 year ago

pssandhu commented 2 years ago

Describe the bug A comic volume with a non-integer number (e.g. v2.5) is not shown on the series page. However, it is detected by kavita as the file appears in the search results but cannot be read.

Edit: Upon further investigation, if I go to Edit Series -> Info then View Files under Volume 2, both volume 2 and 2.5 are listed and both are marked as Chapter 0. This also led me to discover that they are being combined into one volume, so if i read volume 2 it also contains volume 2.5. I'm not sure if this is by design. In my case I found it quite confusing because it was difficult to tell if it was being added to the library and v2.5 was not a continuation of v2 but a collection of side stories.

To Reproduce Steps to reproduce the behavior:

  1. Have a comic series with integer volumes 01 to 10 as well as volume 2.5. There is one file per volume.
  2. Scan comic library to add series to kavita
  3. Go to series page
  4. Volume 2.5 is not shown but volumes 01 to 10 are there

Expected behavior Volume 2.5 should appear between volumes 2 and 3.

Desktop (please complete the following information):

Additional context A different series with one file per issue has a 16.1 issue and that works fine.

majora2007 commented 2 years ago

Can you share an image for me? I'm not understanding on the first read.

pssandhu commented 2 years ago

Series page (volumes tab looks the same): image

Search results for volume 2.5: image

File info for volume 2: image

Should have probably included these to begin with, sorry

majora2007 commented 2 years ago

Okay, understood. I don't think partial volumes are actually supported, but I'll double check.

VegethB commented 2 years ago

File info for volume 2: image

I think kavita decided to put it in "Volume 2," because it is in the "...volume 2..." folder. If you try to create a "Volume 2.5" folder and put the file in there, it probably separates things for you (although x.5 are not supported regardless for kavita), Ex: image image As you can see from the screens, they are not ordered, but randomly added (almost as if that 1.5 is actually the 16 and the 16 the 17 and the 14.5 the 18)

majora2007 commented 2 years ago

I don't think so. Kavita only uses folder names for 2 things. 1 is we can't parse any details from the filename and 2 is when the file is a special, we use folder name as series.

I know that I coded it so volumes have a non float number for grouping. But I did make some changes in the last two releases.

Volumes with floats for books do work but have special logic. I'll take a look but on holiday, so it will be a bit.

pssandhu commented 2 years ago

I have all the volumes in the same folder. Whether the folder has a number in the name or not makes no difference.

majora2007 commented 1 year ago

Took a look, this is working as expected. I believe you likely have a ComicInfo in your 2.5 volume that is saying Volume is 2, hence Kavita is grouping.

Please re-check for me.

image

Liar-Game v01.cbr
Liar-Game v1.5.cbr
pssandhu commented 1 year ago

I've double checked and none of the files have metadata.

I've moved the series to it's own library. If the library type is Comic it doesn't work but if the type is Manga it works as you've shown. Tested on Kavita 0.6.0.0

majora2007 commented 1 year ago

First off, please update to v0.6.1. 6.0 has some security vulnerabilities on it that I patched, along with some other nice fixes.

As far as the issue goes, for Comic, you are correct. Partial volumes are not well supported in the Parser. I can reproduce and will enhance.