Kareadita / Kavita

Kavita is a fast, feature rich, cross platform reading server. Built with the goal of being a full solution for all your reading needs. Setup your own server and share your reading collection with your friends and family.
http://www.kavitareader.com
GNU General Public License v3.0
6.36k stars 331 forks source link

Reading continues past last chapter / volume and loops back to start #2099

Closed DieselTech closed 7 months ago

DieselTech commented 1 year ago

Describe the bug When reading the last chapter or volume in a series, when you get to the very last page the reader will loop back around to chapter 1 again.

To Reproduce Steps to reproduce the behavior:

  1. Go to the last page in a series
  2. Click forward to advance the page
  3. Be amazed your back at the start

Expected behavior In the past there was some kind of warning or popup, can't remember the wording exactly but it was like "You've reached the last page" or "No more pages"

Desktop (please complete the following information):

Additional context So not only does it loop back around to the starting chapter, it starts marking the progress of that chapter as 'in progress" throwing off your resume.

I've also noticed that if your using Volumes and not chapters, that when it loops back to volume 1, that it will be on the last page of volume 1. I was reading Volume 9 and ended on page 150, clicked to advance the page and I was looped back into Volume 1 at page 150.

Reproducible in /library/2/series/347

majora2007 commented 1 year ago

I took a look and it looks like this is a side-effect from another bugfix I did.

I spent 3 hours working on fixing this and was unsuccessful. I'm going to leave it open for anyone to try and tackle, but at the moment, it's a small annoyance and just not something I can solve.

DieselTech commented 1 year ago

Technically this doesn't exist anymore because of the new bug that stops the manga reader from progressing to the next file. You have to exit the image viewer and navigate to the next file to continue reading.

This is still occurring in the latest nightly as if 1/3/24. Not all series exhibit the issue.

majora2007 commented 7 months ago

This should have been auto closed with the Foundational Rework. You can retest on the latest nightly. This should be fixed 100%.