search

Kareadita / Kavita

Kavita is a fast, feature rich, cross platform reading server. Built with the goal of being a full solution for all your reading needs. Setup your own server and share your reading collection with your friends and family.
http://www.kavitareader.com
GNU General Public License v3.0
6.47k stars 340 forks source link

Publisher is derived from special instead of the first volume #3265

Open newyorker123 opened 1 month ago

newyorker123 commented 1 month ago

What happened?

As @majora2007 said, "Publisher is derived from the first issue or volume, it should not come from special unless nothing else is available."

However, when main volumes and Specials come from different publishers, the publisher shown on the series detail page is the first publisher in alphabetical order, instead of the publisher of volume 1.

Here is the test case:

I have a series called test. It has a volume 1 and a special.

On the series detail page, the publisher is taged as aa instead of bb.

The detail page of volume 1 (bb):

image

The detail page of special (aa) :

image

The detail page of the series :

image

What did you expect?

Publisher should be derived from the first issue or volume. It should be bb in the test case.

Kavita Version Number - If you don not see your version number listed, please update Kavita and see if your issue still persists.

0.8.3 - Stable

What operating system is Kavita being hosted from?

Docker (Dockerhub Container)

If the issue is being seen on Desktop, what OS are you running where you see the issue?

Windows

If the issue is being seen in the UI, what browsers are you seeing the problem on?

Chrome

If the issue is being seen on Mobile, what OS are you running where you see the issue?

None

If the issue is being seen on the Mobile UI, what browsers are you seeing the problem on?

No response

Relevant log output

No response

Additional Notes

No response

newyorker123 commented 1 month ago

To clarify, this issue is not caused by special. Even without special, if the volumes have different publishers, the publisher displayed on the series detail page is still the one that comes first alphabetically.

majora2007 commented 1 month ago

Okay I took a look and you are correct in some sense. The UI only shows 1 publisher and there is no order, as Kavita bubbles all individual file publishers into the series.

I just learned 2 weeks ago that there can be multiple publishers for a series, so I had thought up a UX to handle this situation. It will be required to "fix" this issue.

Edit: Note to self, I coded this as publisher-flipper component but need @therobbiedavis or @MrRobotjs to help with css before allowing to switch to this design.