Kareadita / Themes

A central repository for Themes to be used within Kavita
GNU General Public License v3.0
26 stars 8 forks source link

A few e-ink fixes #19

Closed YodaDaCoda closed 3 weeks ago

YodaDaCoda commented 1 month ago

Fix side nav text colour

Before

Screenshot_20240705_132027

After

Screenshot_20240705_132041

Fix dropdown text colour

(fixes #17)

Before:

image

After:

image

Fix card background colour

Before

(this is actually much less readable on an e-ink display than the screenshot shows) image

After

image

YodaDaCoda commented 1 month ago

Looks like my editor removed a bunch of spaces on blank lines. Hope that's okay.

majora2007 commented 1 month ago

Nice fixes. Does the preview image need to be regenerated or the readme need version updating?

I ask because in v0.8.2 Kavita what's a built-in theme management system.

majora2007 commented 1 month ago

I just checked and there is no preview on record. Can you create one and also update the theme version for v0.8.2 (this will be released within days).

YodaDaCoda commented 3 weeks ago

update the theme version for v0.8.2

just in the readme?

majora2007 commented 3 weeks ago

Correct. Add a preview and update the version in the Readme. The theme manager built into Kavita as of v0.8.2 will read that information out.

image

Once done, I can merge this (and then users will auto-update this theme)

YodaDaCoda commented 3 weeks ago

I added a preview, and a couple other tweaks.

I had some trouble getting some bits to be the right colour, looks to be due to Kavita's base style. Should I raise an issue for that over on the main Kavita repo or here?

majora2007 commented 3 weeks ago

I added a preview, and a couple other tweaks.

I had some trouble getting some bits to be the right colour, looks to be due to Kavita's base style. Should I raise an issue for that over on the main Kavita repo or here?

Please do in the main repo. Issues here are for theme issues.