KarelCemus / play-i18n

Multi-format localization plugin for Play framework
12 stars 6 forks source link

Play 2.7 #17

Closed KarelCemus closed 5 years ago

KarelCemus commented 5 years ago

Fixes #16

@dmitchellmim Would you mind to test this? I have upgraded the dependencies but encountered no error and tests pass. Therefore I suggest to test it and if it works, I'll release it.

To test it, use version 1.2.0-SNAPSHOT and include sonatype snapshot repository among resolvers

resolvers += Opts.resolver.sonatypeSnapshots

If the issue persists, I'll trace it, however, it seems that it works.

dmitchellmim commented 5 years ago

Is it published yet? My sbt checks for https://oss.sonatype.org/content/repositories/snapshots/com/github/karelcemus/play-i18n_2.12/1.2.0-SNAPSHOT/play-i18n_2.12-1.2.0-SNAPSHOT.pom but gets a 404. The latest I see is 1.1.2-SNAPSHOT.

KarelCemus commented 5 years ago

My bad, I apologize. I forgot that PRs are not automatically published. Already fixed that, published it manually

dmitchellmim commented 5 years ago

That's the ticket. Thanks for fixing this so quickly!

KarelCemus commented 5 years ago

I am happy it works. Then I will release it in a couple minutes (I want to release 1.1.2 first)

Thanks for testing