KarelCemus / play-i18n

Multi-format localization plugin for Play framework
12 stars 6 forks source link

Allow untrimmed whitespace according to YAML. #19

Closed dmitchellmim closed 5 years ago

dmitchellmim commented 5 years ago

When using Play's default i18n, it's possible to have strings with leading and trailing spaces, but I discovered that this plugin was trimming those spaces. This change adds that functionality, including for multi-line strings (breaking change for anyone using |).

KarelCemus commented 5 years ago

Hi @dmitchellmim, thanks for your contribution! I'll fix build this week and merge this. It looks good.

KarelCemus commented 5 years ago

could you please rebase your branch onto master? I fixed travis and added support of scala 2.13

dmitchellmim commented 5 years ago

Did I do it correctly? I'm used to rebasing in Mercurial but not in Git.

KarelCemus commented 5 years ago

Not exactly, you merged branches, not rebased your branch. The code base is same in the end but commit history is different and more tangled this way. Could you give me a write permission into your branch so I could fix it?

KarelCemus commented 5 years ago

Never mind, I merged it directly outside this PR, therefore I am closing this. Thanks for your contribution

KarelCemus commented 5 years ago

Released