#256 support redis zset

KarelCemus / play-redis

Play framework 2 cache plugin as an adapter to redis-server

Mozilla Public License 2.0

166 stars 44 forks source link

#256 support redis zset #258

Closed Bugsource closed 2 years ago

Bugsource commented 2 years ago

This PR support basic commands of Redis zset. For now, just only support ZADD, ZREM, ZCARD, ZRANGE, ZREVRANGE.

Bugsource commented 2 years ago

Hi @KarelCemus, your suggestion is reasonable, i have checked it out and optimize the code. Please check it again.

Bugsource commented 2 years ago

I've added test cases, but the coverage still report errors. It's strange that it didn't report errors when i commit code first time on PR.

KarelCemus commented 2 years ago

Thank you for your contribution, I am closing this PR since I don't have write access to your branch and creating #259 instead. I added multiple tests to fix the coverage and did some minor refactoring and addressed the comments here.