search

Karen-Lam / pe

0 stars 0 forks source link

Bug 3 - Program feedback to Edit Command not consistent with Add Command #3

Open Karen-Lam opened 1 year ago

Karen-Lam commented 1 year ago

How to replicate? key in edit

Expected: Based on add command, if I key edit, I should see incorrect command format and a line telling me what the correct format is.

Actual: Program tells me there is an invalid input.

image.png

soc-se-bot commented 1 year ago

Team's Response

Thank you for the suggestion, but our team is disagreeing with your premise. The provided error message for edit is valid and should not be compared to the message provided by add command, since edit expects an additional index to be provided by the user. In the example shown in the image, the error message is sufficient in informing the user what is invalid about their input, and is hence not an inconvenience to the user.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Add image.png

Find image.png

Add-image image.png

Edit image.png

The above examples show that for certain commands, after an incorrect command is entered, an error message showing that the command format is wrong, followed by a description of the method and the correct command format is shown. However, for some commands, like edit, delete, or delete-image, a simple line invalid input is given.

For delete and delete-image, the error statement is correct. However, for edit, this error description is incomplete. This is because the edit function does not only require user to key in the index of the person in the contact list but also choose a field to edit. Hence, I think there is a need for a more specific and clearer error description. The error description should have the same format as the add, find or add-image function, so that the user knows exactly where in his command is wrong.