search

KarenKarenWang / cas741_project1

first project for course cas741
Other
2 stars 0 forks source link

Empty “List of Figures” Section can be removed #25

Closed balacij closed 1 year ago

smiths commented 1 year ago

The linked commit (550ef04b54b7771d2403991ebf72df9e8011aa39) only has one change (the addition of a space). It does not address this issue (or the other 5 issues it is said to close).

KarenKarenWang commented 1 year ago

Hi Dr.Smith, I made that by mistake, I made all the changes on the file when for 19-22 issues. So should I reopen these issues and push again? Or is there any way I can fix this;_;

Thanks, Karen

Spencer Smith @.***>于2023年5月4日 周四上午6:57写道：

The linked commit (550ef04 https://github.com/KarenKarenWang/cas741_project1/commit/550ef04b54b7771d2403991ebf72df9e8011aa39) only has one change (the addition of a space). It does not address this issue (or the other 5 issues it is said to close).

— Reply to this email directly, view it on GitHub https://github.com/KarenKarenWang/cas741_project1/issues/25#issuecomment-1534553398, or unsubscribe https://github.com/notifications/unsubscribe-auth/A27YEEWXENAT37K2U42ZDIDXEODRLANCNFSM6AAAAAAVDV3RYY . You are receiving this because you modified the open/close state.Message ID: @.***>

smiths commented 1 year ago

Hello @KarenKarenWang. No, you don't have to reopen the issues. In the future, please do incremental commits. For each issues you do the following: fix the problem, commit the changes, close the issue with a link to the commit that fixes the problem.

KarenKarenWang commented 1 year ago

Hi Dr.Smith,

I will do that for future and the rest of issues.

Thanks, Ning

Spencer Smith @.***>于2023年5月4日 周四上午11:44写道：

Hello @KarenKarenWang https://github.com/KarenKarenWang. No, you don't have to reopen the issues. In the future, please do incremental commits. For each issues you do the following: fix the problem, commit the changes, close the issue with a link to the commit that fixes the problem.

— Reply to this email directly, view it on GitHub https://github.com/KarenKarenWang/cas741_project1/issues/25#issuecomment-1535008119, or unsubscribe https://github.com/notifications/unsubscribe-auth/A27YEEUECOEVMKPLPKH3MYTXEPFFXANCNFSM6AAAAAAVDV3RYY . You are receiving this because you were mentioned.Message ID: @.***>