search

KarimMokhtar / react-drag-drop-files

Light and simple Reactjs drag and drop files library to use with very flexible options to change, so you put whatever the design you want for your drop-area. Users can drag and drop or even select the file anywhere in the window.
MIT License
248 stars 91 forks source link

adding huskey for precommit checking #47

Open KarimMokhtar opened 2 years ago

uwemneku commented 2 years ago

Hi, Thanks for this awesome library. I can and would love to help with this task. Can I please know the commands that should be ran during the pre commit-checks ?

KarimMokhtar commented 2 years ago

Hi @uwemneku , Thanks so much for your interest. Basically, we need to add the semantic commit checking so that we can avoid this failing in the pipeline. Then we can build up on that in the future.

uwemneku commented 2 years ago

@KarimMokhtar This sounds a little bit advanced, the most I can do with husky, is set up a pre-commit hook to run npm commands like npx tsc.

Please is there an article/video which I can read to help me understand the task better ?

KarimMokhtar commented 2 years ago

@uwemneku It kinda similar except for you gonna need to use something called "lint-staged", Here is the docs for that task: https://medium.com/@anshul.kashyap03/set-up-git-hooks-with-husky-and-lint-staged-angular-example-a4d46e440ba5 Note: Please ignore the prettier part for now

uwemneku commented 2 years ago

@KarimMokhtar Thanks for the article, I see a PR has been made for this already. I see if there are other issues I can contribute to. Thanks again 👍