search

Karitham / WaifuBot

discord waifu / husbando gacha bot
MIT License
39 stars 9 forks source link

Update GraphQL Queries #66

Closed BellezaEmporium closed 3 years ago

BellezaEmporium commented 3 years ago

Reason for that is, since the result of Media is a node linked to the Character, there's no need for us to search for it by popularity after. Of course, the character could be appearing in many versions of the anime/manga, but well, we do not even show it on Discord's side.

Karitham commented 3 years ago

Sorting by popularity has the advantage of usually bringing up the main show instead of appearances or side shows, there may be a better parameter than popularity, but removing it will cause a lot of side shows to show up in results

BellezaEmporium commented 3 years ago

For now, I have not seen the changes quite well, the Media results correspond to the usual results we would get. Maybe that, by default, it searches for the most popular occurence linked to the anime/manga the character appears in.

Here, as an example : image image

Karitham commented 3 years ago

Thanks for the changes.

The conflicts are too annoying to fix, so I'll just be changing to few lines you changed on the main branch.

Thanks for this