Karl-HeinzSchneider / WoW-DragonflightUI

World of Warcraft (classic) Addon to bring the new Retail UI to WoW Classic!
https://www.curseforge.com/wow/addons/dragonflight-ui-classic
MIT License
30 stars 13 forks source link

Character pane is broken with popular addon CharacterStatsClassic #132

Closed sandervspl closed 1 month ago

sandervspl commented 1 month ago

image

https://www.curseforge.com/wow/addons/characterstatsclassic

It's a very popular addon, used by many people playing classic. Is it possible to get this fixed on your side or is this not possible?

Karl-HeinzSchneider commented 1 month ago

Hey! I made a quick fix with 7e9c1347cc889645b3745e49810dba185bdd1ec3 : image

Karl-HeinzSchneider commented 1 month ago

But you're using some other addon that changes the CharacterFrame, right? I see Gearscore, but also the rotate button is different, and theres a button left of the upper trinket slot.

Karl-HeinzSchneider commented 1 month ago

TacoTip compatibility: 3a728a072fc55598df23b972060663dbb1fdf240

sandervspl commented 1 month ago

But you're using some other addon that changes the CharacterFrame, right? I see Gearscore, but also the rotate button is different, and theres a button left of the upper trinket slot.

That's probably leatrix plus. It has many interface enhancements. Might be nice to get compat with those as well, as leatrix is also super popular

Karl-HeinzSchneider commented 1 month ago

I'm using leatrix plus myself, but not every option is useful, and nearly every default option works fine. It's not possible to make everything compatible, because LTP is destrucftive, and doesn't really care about other addons (except for sometimes ElvUI). The old frames (Character, Talents, Spellbook etc) are 20 years old and not coded in a consistent style (and coded like shit tbh), and it's not possible to alter them without drawing custom textures for every frame, so I had to override the positions etc to match the modern style.

Karl-HeinzSchneider commented 1 month ago

You're using the 'Enhance Dressup' from LeatrixPlus, but also some other addon, because this doesn't add the arrow button left of your trinket1 slot.

sandervspl commented 1 month ago

Yes, correct, it's the enhanced dressup option. No worries if compat becomes too difficult. I'll disable it for now! Thanks for all the other compat work. Appreciate it

Karl-HeinzSchneider commented 1 month ago

New version is on its way to curseforge. Please let me know if you encounter (Era specific?) errors, or have any other ideas for improvements! I'm working on getting every old Era frame into the modern Dragonflight style; Cata is more or less done with that.