KarlJorgensen / virgin-media-hub3

Python API and command line interface to the Virgin Media Hub 3 broadband router
GNU General Public License v3.0
78 stars 18 forks source link

Add option to add a forwarding of a range of ports #19

Open jorrit opened 1 year ago

rkr87 commented 1 year ago

Need to amend as below;

        pflist.append(
        proto=snmp.IPProtocol[args.protocol],
        ext_port_start=args.external_port,
        ext_port_end=args.external_port + args.number_of_ports - 1,
        local_port_start=args.internal_port,
        local_port_end=args.internal_port + args.number_of_ports - 1,
        local_addr=args.internal_ip)

otherwise it will open 1 additional port for every request.

jorrit commented 1 year ago

That off by one error again! Thanks @rkr87 !