search

KarlOfDuty / SCPDiscord

A NWAPI plugin which adds remote interaction to an SCP:SL server through Discord.
https://karlofduty.com
GNU General Public License v3.0
15 stars 15 forks source link

Fix problem with incorrect time definition #164

Closed TouDead closed 6 months ago

TouDead commented 6 months ago

I try to use 1h30m and get 130 hours. So I write this code to fix this

KarlOfDuty commented 6 months ago

This is a great addition, thanks!

However, the code doesn't seem to compile at the moment, so you will need to fix that first.

KarlOfDuty commented 6 months ago

But if you think your second version is better you can make a version of it that uses the SecondsToCompoundTime function instead of implementing that code yourself there, I'd be fine with that too.

TouDead commented 6 months ago

Was busy for a few days but came back to finish the job. I took into account the wishes for the readability of the code and brought it into working condition, with all the necessary corrections on my part and yours.

KarlOfDuty commented 6 months ago

The dev build for this PR is available here: https://jenkins.karlofduty.com/blue/organizations/jenkins/NWAPI%2FSCPDiscord/detail/master/213/artifacts