search

Karlinator / roll20-character-sheets

My fork of the Roll20 characters sheets. Used for developing the Stars Without Number: Revised sheet. My code here: https://github.com/Karlinator/roll20-character-sheets/tree/master/Stars_Without_Number_Revised
MIT License
1 stars 3 forks source link

Attack rolls while using First edition skill list. #5

Closed Shotty4Life closed 6 years ago

Shotty4Life commented 6 years ago

Hello.

I noticed that since the sheet was updated to version 1.6, you added an option to use First edition skill set optionally. Personally, I prefer the First edition skill list, so this is great.

Buuut as it happens, attack rolls are broken when using the First edition skills option. The attack rolls always default to using Revised edition "Shoot" skill. Tested this by jumping between the two skill list settings and changing combat related skill levels. While First edition skill list was active, it did not matter which skill was selected for a weapon, it always used what ever skill level I had left for Shoot skill in Revised edition settings.

I probably should also mention: I noticed some weird behavior from the weapons skill selection drop-down menu. When I create a weapon (add a new row under weapons) while using First edition skill list, it always shows Revised edition list for a second, before updating to First edition skill list. Don't know if that "lag" (I guess) has anything to do with the issue.

Karlinator commented 6 years ago

Thanks for bringing this up. I located the bug and fixed it. The fix should go live early next week (typically Monday/Tuesday depending on you time zone) when Roll20 approves pull requests.

The delay before it switches to the first edition skill list is unrelated but unavoidable because of how Roll20 works. It needs to be forced to run some things, and that only happens after a field in the repeating section is updated.