Consider changing the name of the `name` attribute

Karlinator / roll20-character-sheets

My fork of the Roll20 characters sheets. Used for developing the Stars Without Number: Revised sheet. My code here: https://github.com/Karlinator/roll20-character-sheets/tree/master/Stars_Without_Number_Revised

MIT License

1 stars 3 forks source link

Consider changing the name of the `name` attribute #65

Closed svmnotn closed 4 years ago

svmnotn commented 4 years ago

Changing the character's name attribute from name to character_name would link the character's name to that of the journal, as instructed in Roll20's docs

Karlinator commented 4 years ago

That's probably both a good idea and easy to implement. I can't at the moment think of anything tied to the character name, so it should be completely painless.

joesinghaus commented 4 years ago

Related QoL improvement: watch changes to character name and replace any quotes with some kind of typographic quotes so that entering quotes does not break chat menus.

Karlinator commented 4 years ago

Right, because attribute values are not escaped in the roll syntax because sometimes you might want to put quotes in an attribute and have them act like quotes.