The position: absolute used for this text caused the text to stay at the same position when the user scrolls through the changes list (zooming to 200% while making the window as small as possible is the best way to repro this issue).
This PR switches to a position: relative (and all other positioning changes needed to position it properly). The only side-effect of this change is that now when the button is focused, the text is also outlined (see the screenshot below).
Screenshots
Release notes
Notes: [Fixed] Add/Remove Co-authors hint text is positioned correctly when scrolling through the changes list
xref. https://github.com/github/accessibility-audits/issues/8673
Description
The
position: absoluteused for this text caused the text to stay at the same position when the user scrolls through the changes list (zooming to 200% while making the window as small as possible is the best way to repro this issue).This PR switches to a
position: relative(and all other positioning changes needed to position it properly). The only side-effect of this change is that now when the button is focused, the text is also outlined (see the screenshot below).Screenshots
Release notes
Notes: [Fixed] Add/Remove Co-authors hint text is positioned correctly when scrolling through the changes list
Publicación original de @sergiou87 en https://github.com/desktop/desktop/pull/18929