Karm / mandrel-integration-tests

Integration tests for GraalVM and its Mandrel distribution. Runs Quarkus, Helidon and Micronaut applications and small targeted reproducers. The focus is solely on native-image utility and compilation of Java applications into native executables.
Apache License 2.0
5 stars 3 forks source link

Update version detection for GraalVM 23.0+ #144

Closed jerboaa closed 1 year ago

jerboaa commented 1 year ago

An update so as to detect version strings like these as well:

native-image 17.0.6 2023-01-17
OpenJDK Runtime Environment Mandrel-23.1.0-dev (build 17.0.6+10)
OpenJDK 64-Bit Server VM Mandrel-23.1.0-dev (build 17.0.6+10, mixed mode)
zakkak commented 1 year ago

Version tests are failing (see https://github.com/Karm/mandrel-integration-tests/issues/145), I am also wondering whether it would be worth bringing in the unit tests from Quarkus as well.

jerboaa commented 1 year ago

Version tests are failing (see #145), I am also wondering whether it would be worth bringing in the unit tests from Quarkus as well.

Version tests where failing because of a stupid issue (unconditionally returning UNKNOWN via MVersion.of()). Sigh.

@@ -247,7 +247,7 @@ public class UsedVersion {
             }
             LOGGER.infof("The test suite runs with Mandrel version %s %s, JDK %d.%d.%d%s.",
                     mandrelVersion.version.toString(), inContainer ? "in container" : "installed locally on PATH", mandrelVersion.jdkFeature, mandrelVersion.jdkInterim, mandrelVersion.jdkUpdate, mandrelVersion.betaBits);
-            return UNKNOWN_VERSION;
+            return mandrelVersion;
         }

Fixed now.

I'm not sure we need the unit tests from Quarkus here. I've just pushed a commit with a basic test for the 3-line version, though.

zakkak commented 1 year ago

The CI doesn't seem happy with the new unit test :/

jerboaa commented 1 year ago

The CI doesn't seem happy with the new unit test :/

Yes, sigh. Looking into it.

EDIT: Should all be fixed now.

jerboaa commented 1 year ago

@zakkak Please take another look when you get a chance. Thanks!

jerboaa commented 1 year ago

This debuginfo related failure seems not related to this patch:

Error:  Failures: 
Error:    DebugSymbolsTest.debugSymbolsQuarkus:203