Closed jerboaa closed 1 year ago
Version tests are failing (see https://github.com/Karm/mandrel-integration-tests/issues/145), I am also wondering whether it would be worth bringing in the unit tests from Quarkus as well.
Version tests are failing (see #145), I am also wondering whether it would be worth bringing in the unit tests from Quarkus as well.
Version tests where failing because of a stupid issue (unconditionally returning UNKNOWN
via MVersion.of()
). Sigh.
@@ -247,7 +247,7 @@ public class UsedVersion {
}
LOGGER.infof("The test suite runs with Mandrel version %s %s, JDK %d.%d.%d%s.",
mandrelVersion.version.toString(), inContainer ? "in container" : "installed locally on PATH", mandrelVersion.jdkFeature, mandrelVersion.jdkInterim, mandrelVersion.jdkUpdate, mandrelVersion.betaBits);
- return UNKNOWN_VERSION;
+ return mandrelVersion;
}
Fixed now.
I'm not sure we need the unit tests from Quarkus here. I've just pushed a commit with a basic test for the 3-line version, though.
The CI doesn't seem happy with the new unit test :/
The CI doesn't seem happy with the new unit test :/
Yes, sigh. Looking into it.
EDIT: Should all be fixed now.
@zakkak Please take another look when you get a chance. Thanks!
This debuginfo related failure seems not related to this patch:
Error: Failures:
Error: DebugSymbolsTest.debugSymbolsQuarkus:203
An update so as to detect version strings like these as well: