search

Karm / mandrel-integration-tests

Integration tests for GraalVM and its Mandrel distribution. Runs Quarkus, Helidon and Micronaut applications and small targeted reproducers. The focus is solely on native-image utility and compilation of Java applications into native executables.
Apache License 2.0
5 stars 3 forks source link

AppReproducersTest.versionsParsingMandrel failing after the version change upstream #145

Closed jerboaa closed 1 year ago

jerboaa commented 1 year ago

Currently UsedVersion doesn't implement the 3-line version parsing added with https://github.com/oracle/graal/pull/6302 and, thus, the version test fails:

[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 25.956 s <<< FAILURE! - in org.graalvm.tests.integration.AppReproducersTest
[ERROR] versionsParsingMandrel{TestInfo}  Time elapsed: 25.672 s  <<< FAILURE!
org.opentest4j.AssertionFailedError: Sanity check that Graal version parsing worked! ==> expected: <TargetSub: Hello!> but was: <Sub: Hello!>
    at org.graalvm.tests.integration.AppReproducersTest.versionsParsingMandrel(AppReproducersTest.java:797)

[INFO] 
[INFO] Results:
[INFO] 
[ERROR] Failures: 
[ERROR]   AppReproducersTest.versionsParsingMandrel:797 Sanity check that Graal version parsing worked! ==> expected: <TargetSub: Hello!> but was: <Sub: Hello!>
[INFO] 
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0

However, even with a fix for the version parsing as proposed in #144 we still get the failure.

That is because of two more fixes missing:

  1. Upstream issue related to -Dorg.graalvm.version no longer being passed to the image builder: https://github.com/oracle/graal/issues/6379
  2. Mandrel packaging issue not setting -Dorg.graalvm.version to begin with: https://github.com/graalvm/mandrel-packaging/pull/331

With all 3 fixes in, the test passes for me.

jerboaa commented 1 year ago

Once #144 merges, we can close this as all the needed fixes are in.