search

Karm / mandrel-integration-tests

Integration tests for GraalVM and its Mandrel distribution. Runs Quarkus, Helidon and Micronaut applications and small targeted reproducers. The focus is solely on native-image utility and compilation of Java applications into native executables.
Apache License 2.0
5 stars 3 forks source link

RuntimesSmokeTest.quarkusFullMicroProfile/JFRTest.jfrPerfTest fail due to new Quarkus warnings with quarkus main (3.6) #220

Closed jerboaa closed 7 months ago

jerboaa commented 7 months ago

The RuntimesSmokeTest.quarkusFullMicroProfile test fails in CI with JDK 22 + GraalVM 24.0 with:

2023-11-13 02:28:31,843 WARN  [io.qua.run.con.DeprecatedRuntimePropertiesRecorder] (main) The 'quarkus.http.auth.form.redirect-after-login' config property is deprecated and should not be used anymore ==> expected: <true> but was: <false>
Error:    RuntimesSmokeTest.quarkusFullMicroProfile:192->testRuntime:157 build-and-run.log log should not contain error or warning lines that are not whitelisted. See /home/runner/work/mandrel/mandrel/mandrel-integration-tests/testsuite/target/archived-logs/org.graalvm.tests.integration.RuntimesSmokeTest/quarkusFullMicroProfile/build-and-run.log and check these offending lines: 
2023-11-13 03:03:04,462 WARN  [io.qua.run.con.DeprecatedRuntimePropertiesRecorder] (main) The 'quarkus.http.auth.form.redirect-after-login' config property is deprecated and should not be used anymore ==> expected: <true> but was: <false>

and

Error:  Failures: 
Error:    JFRTest.jfrPerfTest:176->jfrPerfTestRun:219 build-and-run.log log should not contain error or warning lines that are not whitelisted. See /home/runner/work/mandrel/mandrel/mandrel-integration-tests/testsuite/target/archived-logs/org.graalvm.tests.integration.JFRTest/jfrPerfTest/build-and-run.log and check these offending lines: 
2023-11-13 02:28:29,532 WARN  [io.qua.run.con.DeprecatedRuntimePropertiesRecorder] (main) The 'quarkus.http.auth.form.redirect-after-login' config property is deprecated and should not be used anymore

See: https://github.com/graalvm/mandrel/actions/runs/6844550940/job/18609261996#step:11:18840

jerboaa commented 7 months ago

I have reproduced this locally with the quarkus microprofile app, but I have no idea where the property is coming from:

$ java -jar target/quarkus-app/quarkus-run.jar 
__  ____  __  _____   ___  __ ____  ______ 
 --/ __ \/ / / / _ | / _ \/ //_/ / / / __/ 
 -/ /_/ / /_/ / __ |/ , _/ ,< / /_/ /\ \   
--\___\_\____/_/ |_/_/|_/_/|_|\____/___/   
2023-11-13 18:08:21,863 WARN  [io.qua.run.con.DeprecatedRuntimePropertiesRecorder] (main) The 'quarkus.http.auth.form.redirect-after-login' config property is deprecated and should not be used anymore
2023-11-13 18:08:22,130 INFO  [io.quarkus] (main) quarkus-full-microprofile 1.0.0-SNAPSHOT on JVM (powered by Quarkus 999-SNAPSHOT) started in 0.917s. Listening on: http://0.0.0.0:8080
2023-11-13 18:08:22,131 INFO  [io.quarkus] (main) Profile prod activated. 
2023-11-13 18:08:22,131 INFO  [io.quarkus] (main) Installed features: [cdi, jaeger, rest-client, resteasy, security, smallrye-context-propagation, smallrye-fault-tolerance, smallrye-health, smallrye-jwt, smallrye-metrics, smallrye-openapi, smallrye-opentracing, vertx]
^C2023-11-13 18:08:29,397 INFO  [io.quarkus] (Shutdown thread) quarkus-full-microprofile stopped in 0.221s

A simple grep doesn't return anything for me....

zakkak commented 7 months ago

Not sure but I suspect it is coming from https://github.com/quarkusio/quarkus/blob/b08cf2f100a24b7b7225756d558303236f713846/extensions/vertx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/security/FormAuthenticationMechanism.java#L90

and was introduced with https://github.com/quarkusio/quarkus/pull/37022

michalvavrik commented 7 months ago

Please see https://github.com/quarkusio/quarkus/issues/37072.

jerboaa commented 7 months ago

Thanks!

jerboaa commented 7 months ago

I'm proposing to allow-list the deprecation lines in #222 until we have a proper fix in Quarkus so as to reduce test noise and miss issues because of this known problem.

jerboaa commented 7 months ago

https://github.com/quarkusio/quarkus/issues/37072 fixed this for us.