search

Karm / mandrel-integration-tests

Integration tests for GraalVM and its Mandrel distribution. Runs Quarkus, Helidon and Micronaut applications and small targeted reproducers. The focus is solely on native-image utility and compilation of Java applications into native executables.
Apache License 2.0
5 stars 3 forks source link

Adapt quarkus-full-microprofile based tests to work with Quarkus >= 3.6.0 #225

Closed zakkak closed 7 months ago

zakkak commented 7 months ago

Starting with Quarkus 3.6.0 quarkus-smallrye-opentracing is no longer a core extension. quarkus-full-microprofile depends on it and thus fails with Quarkus >= 3.6.0 (as observed in https://github.com/Karm/mandrel-integration-tests/issues/223)

https://github.com/Karm/mandrel-integration-tests/pull/224 disabled quarkus-full-microprofile based tests for Quarkus >= 3.6.0, which comes with the big drawback that we are no longer running 3 important tests.

@jerboaa suggested in https://github.com/Karm/mandrel-integration-tests/issues/223#issuecomment-1820603355:

how about we produce a profile that activates based on the quarkus version and adds the quarkiverse dependency for later versions?

zakkak commented 7 months ago

Regarding @jerboaa 's suggestion:

One potential issue I see with that is that our test will then depend on a quarkiverse dependency which I expect to be tricky when testing Quarkus main.

Since I am not familiar with the code nor with the testing goals of it I will leave that to @Karm. Perhaps we can completely replace it or drop the smallrye-opentracing dependency.

Karm commented 7 months ago

I will create a patch. This is IMHO connected to MicroProfile specification that is getting rid of a one monitoring API in favor of another, i.e. we get rid of Jaeger things in favor of OpenTelemetry for good.

We will need .patch so as older Qurkus versions keep working and we can have the same app. Given the simplicity of the app, I think it's still more manageable than having a separate test app in apps dir.