search

Karm / mandrel-integration-tests

Integration tests for GraalVM and its Mandrel distribution. Runs Quarkus, Helidon and Micronaut applications and small targeted reproducers. The focus is solely on native-image utility and compilation of Java applications into native executables.
Apache License 2.0
5 stars 3 forks source link

New bike shed paint: mvn formatter:format -pl testsuite #231

Closed Karm closed 7 months ago

Karm commented 7 months ago

I set up a formatter, it reflowed everything not wrapped in //@formatter:off and now I don't know whether I like it or not. Do we need it? It's the contemporary Quarkus one + longer lines.

It does not touch the test apps, just the test code.

Perhaps we just keep the xml file for IDE?

mvn formatter:format -pl testsuite
zakkak commented 7 months ago

and now I don't know whether I like it or not

IMO there is no real need to reformat everything (and will only make things harder to track through git log/blame). I would prefer to have the new formatter in and reformat only edited lines as we go.

Also note that I see some changes (e.g. the removal of tests for older Mandrel versions) that don't seem to be from the reformat, and would prefer to have them in a separate commit.

Karm commented 7 months ago

and now I don't know whether I like it or not

IMO there is no real need to reformat everything (and will only make things harder to track through git log/blame). I would prefer to have the new formatter in and reformat only edited lines as we go.

Also note that I see some changes (e.g. the removal of tests for older Mandrel versions) that don't seem to be from the reformat, and would prefer to have them in a separate commit.

Ack. I'll just leave the xml file for people to use in IDE.